Skip to content

Variations: Completion notices #8578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 10, 2023
Merged

Variations: Completion notices #8578

merged 2 commits into from
Jan 10, 2023
+56 −1

Conversation

@Ecarrion
Copy link
Contributor

@Ecarrion Ecarrion commented Jan 6, 2023

Closes: #8574

Why

This PR takes care of showing notices when the generate variation process finishes.
The variation process can finish with variations generated or without variations generated

Demo

variations-created-succesfully.mov
no-variations-created.mov

Testing Steps

  • Open a product that has variations left to generate
  • Start the "Generate all variations" process
  • After generation see that a notice indicating that variations were generated appears.
  • Start the "Generate all variations" process again
  • See that a notice indicating that there are no variations to generate appear.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@Ecarrion Ecarrion added the feature: variation list Related to the variations list for variable products. label Jan 6, 2023
@Ecarrion Ecarrion added this to the 11.8 milestone Jan 6, 2023
@Ecarrion Ecarrion requested a review from ealeksandrov January 6, 2023 21:58
@Ecarrion Ecarrion linked an issue Jan 6, 2023 that may be closed by this pull request
Variations: Inform about variations created #8574
Closed
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jan 6, 2023

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr8578-bbe076c on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@spencertransier spencertransier modified the milestones: 11.8, 11.9 Jan 7, 2023
ealeksandrov
ealeksandrov approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@ealeksandrov ealeksandrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Base automatically changed from issue/8491-loading-indicators to trunk January 10, 2023 12:20
@Ecarrion Ecarrion merged commit eb31852 into trunk Jan 10, 2023
@Ecarrion Ecarrion deleted the issue/8574-finished-notices branch January 10, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ealeksandrov ealeksandrov ealeksandrov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

feature: variation list Related to the variations list for variable products.

Projects

None yet

Milestone

11.9

Development

Successfully merging this pull request may close these issues.

Variations: Inform about variations created

5 participants

@Ecarrion @wpmobilebot @ealeksandrov @spencertransier